Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68359 )
Change subject: [RFC] tests: Replace pre-processor ifdefs with weak functions ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: I understand this is not the end result (not the final version) but it looks to me as a positive improvement. To be specific, the whole chain of patches, not just this one but the chain as a whole looks positive to me.
The most important aspects I am thinking about are 1) Does it make easier for contributors to add new tests? Specifically new tests for programmers that has none yet. I think it does make it a bit easier. Less code in each <programmer_name>.c and no need to add a source file to meson build every time 2) Does it make easier to spot and detect the problem while development? For example if one forgets to add line in weaks.c would jenkins complain? I understand yes, probably fails to link?
File tests/weaks.c:
https://review.coreboot.org/c/flashrom/+/68359/comment/0c976b0d_57f114b2 PS1, Line 19: SKIP_TEST If the macro is only used in this one file, maybe it can be defined in this one file? And then maybe you can include tests.h only to have symbols for test methods names? The whole lifecycle.h is not needed here.