Attention is currently required from: Nico Huber, Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: fixed unintialized value passed to function ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/00c2f4f0_c7cdf136 PS1, Line 7: unintialized typo: uninitialized
https://review.coreboot.org/c/flashrom/+/62725/comment/263e15b9_3a17e6f2 PS1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns Please wrap commit message lines at 72 characters, c.f. https://flashrom.org/Development_Guidelines#Commit_message
https://review.coreboot.org/c/flashrom/+/62725/comment/9e0dc5cc_53e5d7e6 PS1, Line 9: y t
https://review.coreboot.org/c/flashrom/+/62725/comment/10d6e9e4_9a381665 PS1, Line 10: flase typo: false
https://review.coreboot.org/c/flashrom/+/62725/comment/dfae669b_b67dbbc2 PS1, Line 10: unintialzed 2 typos: uninitialized
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/62725/comment/25bbcab4_96978501 PS1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0; Since these are pointers, I'd use NULL.
Also, please add spaces around `=`.