Attention is currently required from: Nico Huber, Light.

Patch set 1:Code-Review +1

View Change

6 comments:

• Commit Message:

  • Patch Set #1, Line 7: unintialized

    typo: uninitialized

  • Patch Set #1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns

    Please wrap commit message lines at 72 characters, c.f. https://flashrom.org/Development_Guidelines#Commit_message

  • Patch Set #1, Line 9: y

    t

  • Patch Set #1, Line 10: flase

    typo: false

  • Patch Set #1, Line 10: unintialzed

    2 typos: uninitialized

• File libflashrom.c:

  • Patch Set #1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0;

    Since these are pointers, I'd use NULL.

    Also, please add spaces around `=`.

To view, visit change 62725. To unsubscribe, or for help writing mail filters, visit settings.