Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner. Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57810/comment/7f83baa5_352bd8d0 PS2, Line 22: : TODOs: : - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment) : - reword commit message : - man page for both `csgpiol`, `gpiol` :
TODOs
Thank you for being thorough about this!
Commit Message:
https://review.coreboot.org/c/flashrom/+/57810/comment/20a01611_b147c4bb PS4, Line 20: In the event that : both arguments are specified, gpiol is used. This paragraph is also the original commit message, right?
Patchset:
PS4: This is a thoughtful proposal. Thank you!
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/ce3a1449_9c765e4c PS2, Line 530: /* * * * * * * * * * * * * * * * * * * * * * * * * * * : * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` * : * * * * * * * * * * * * * * * * * * * * * * * * * * */ : case 'C': : cs_bits |= 1 << gpiol_pin; : pindir |= 1 << gpiol_pin; : break; :
RFC: 'C' could replace `csgpiol` […]
I like it.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/d48e6ef4_334c0266 PS4, Line 90: * The variables `cs_bits` and `pindir` store the values for the : * "set data bits low byte" MPSSE command that sets the initial : * state and the direction of the I/O pins. `cs_bits` pins default : * to high and will be toggled during SPI transactions. All other : * output pins will be kept low all the time. GPIOL* pins are : * configured as inputs, while it's possible to use one of them as : * additional CS# signal through the parameter `csgpiol`. On exit, : * all pins will be reconfigured as inputs Reminder: this comment will need updating.