Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner.

View Change

5 comments:

• Commit Message:

  • Patch Set #2, Line 22:

    
    TODOs:
     - discuss merging `csgpiol` into `gpiol` as 'C' (see RFC comment)
     - reword commit message
     - man page for both `csgpiol`, `gpiol`
    
    

    TODOs

    Thank you for being thorough about this!

• Commit Message:

  • Patch Set #4, Line 20:

    In the event that
    both arguments are specified, gpiol is used.
    

    This paragraph is also the original commit message, right?

• Patchset:

  • Patch Set #4:

    This is a thoughtful proposal. Thank you!

• File ft2232_spi.c:

  • Patch Set #2, Line 530:

    					/* * * * * * * * * * * * * * * * * * * * * * * * * * *
    					 * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` *
    					 * * * * * * * * * * * * * * * * * * * * * * * * * * */
    					case 'C':
    						cs_bits  |= 1 << gpiol_pin;
    						pindir   |= 1 << gpiol_pin;
    						break;
    
    

    RFC: 'C' could replace `csgpiol` […]

    I like it.

• File ft2232_spi.c:

  • Patch Set #4, Line 90:

     * The variables `cs_bits` and `pindir` store the values for the
     * "set data bits low byte" MPSSE command that sets the initial
     * state and the direction of the I/O pins. `cs_bits` pins default
     * to high and will be toggled during SPI transactions. All other
     * output pins will be kept low all the time. GPIOL* pins are
     * configured as inputs, while it's possible to use one of them as
     * additional CS# signal through the parameter `csgpiol`. On exit,
     * all pins will be reconfigured as inputs
    

    Reminder: this comment will need updating.

To view, visit change 57810. To unsubscribe, or for help writing mail filters, visit settings.