Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS5:
I'll bring back the mappers for the SPI masters. […]
I brought back the SPI master mappers, it was pretty straightforward. It looks like physmap is not needed for the other SPI masters (besides sb600 promontory and wbsio), but I left them unchanged since they weren't tested.
I found a couple of AMD boards, I will need to check what chipsets they are but I should be able to test some of those next week.
I didn't bring back mappers on opaque masters, the only one other than ICH hwseq that had a custom mapper was dummy, and it doesn't look like dummy needs it for opaque.
PS5:
Yeah definitely, agree that would make this more incremental which would be great. […]
Could you update those with the current master (minor merge conflicts) and separate them from CB:67393? (It looks like 67393 is blocked in review and I think these are independent.)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/125f71ed_ae590ce7 PS2, Line 1865: &mapper_phys
I don't think mapping is used here. As far as I know it is only used for the par_master in internal. […]
The mapper is back for this SPI master now, I don't think it is needed but I'll leave that to be changed separately when it can be tested.
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/4a8bedaf_437e65cc PS5, Line 919: 1024
Ack
We have `MiB` too apparently! Done