Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev.
4 comments:
Patchset:
I'll bring back the mappers for the SPI masters. […]
I brought back the SPI master mappers, it was pretty straightforward. It looks like physmap is not needed for the other SPI masters (besides sb600 promontory and wbsio), but I left them unchanged since they weren't tested.
I found a couple of AMD boards, I will need to check what chipsets they are but I should be able to test some of those next week.
I didn't bring back mappers on opaque masters, the only one other than ICH hwseq that had a custom mapper was dummy, and it doesn't look like dummy needs it for opaque.
Yeah definitely, agree that would make this more incremental which would be great. […]
Could you update those with the current master (minor merge conflicts) and separate them from CB:67393? (It looks like 67393 is blocked in review and I think these are independent.)
File ichspi.c:
Patch Set #2, Line 1865: &mapper_phys
I don't think mapping is used here. As far as I know it is only used for the par_master in internal. […]
The mapper is back for this SPI master now, I don't think it is needed but I'll leave that to be changed separately when it can be tested.
File serprog.c:
Ack
We have `MiB` too apparently! Done
To view, visit change 67695. To unsubscribe, or for help writing mail filters, visit settings.