Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: ft2232_spi: reintroduce generic GPIOL control
......................................................................
Patch Set 18: Code-Review+2
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/c3b97c30_33680437
PS16, Line 513: arg_gpiol[3] = extract_programmer_param("gpiol3");
Also just noticed: In the current form, any premature `return` inside
the loop would leak some of these arg_gpiol[] pointers.
Sure, any return would need `free(arg)` before. That also applies to the solutions above, doesn't it?
Well, the original solution actually required a loop over free(). Now it's
just a single free().
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a
Gerrit-Change-Number: 57810
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 30 Sep 2021 13:58:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment