Attention is currently required from: Felix Singer, Angel Pons, Michael Niewöhner.

Patch set 18:Code-Review +2

View Change

1 comment:

• File ft2232_spi.c:

  • Patch Set #16, Line 513: arg_gpiol[3] = extract_programmer_param("gpiol3");

    Also just noticed: In the current form, any premature `return` inside
    the loop would leak some of these arg_gpiol[] pointers.

    Sure, any return would need `free(arg)` before. That also applies to the solutions above, doesn't it?

    Well, the original solution actually required a loop over free(). Now it's
    just a single free().

To view, visit change 57810. To unsubscribe, or for help writing mail filters, visit settings.