Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58561 )
Change subject: Add -W options from Makefile into meson warning_flags ......................................................................
Add -W options from Makefile into meson warning_flags
Makefile options were more restrictive and produced more warnings. This patch adds missing warning options into meson build.
Makefile also has -Wall and -Wextra specified explicitly, however this is covered by warning_level=2 which is already set in meson.build. warning_level info: https://github.com/mesonbuild/meson/issues/3275
There are few warning options that are present in meson, but not in Makefile. These are left as is.
TEST=ninja test shows no warnings and tests pass
Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25 Signed-off-by: Anastasia Klimchuk aklm@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/58561 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Thomas Heijligen src@posteo.de --- M meson.build 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved
diff --git a/meson.build b/meson.build index 32e31df..e9eb4d2 100644 --- a/meson.build +++ b/meson.build @@ -13,6 +13,8 @@
# hide/enable some warnings warning_flags = [ + '-Wshadow', + '-Wmissing-prototypes', '-Wwrite-strings', '-Wno-unused-parameter', '-Wno-address-of-packed-member',
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.