[flashrom-gerrit] Change in flashrom[master]: bitbang-spi.c: support clock polarity and phase

[Angel Pons (Code Review)]

Attention is currently required from: Xiang Wang, Stefan Reinauer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )

Change subject: bitbang-spi.c: support clock polarity and phase
......................................................................

Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/49255/comment/de4c7599_4fe4ad03 
PS1, Line 8: 
Without any reasoning given as to why this functionality is necessary, I think this patch is harmful.

File bitbang_spi.c:

https://review.coreboot.org/c/flashrom/+/49255/comment/8ad528e8_2f2ba8d0 
PS1, Line 78: bitbang_spi_xfer(
> this is its own patch.

I would not approve of such a patch either. Having two separate functions for read and write is much more efficient, and speed matters when bitbanging.