Attention is currently required from: Xiang Wang, Stefan Reinauer, Edward O'Callaghan.

Patch set 1:Code-Review -1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    Without any reasoning given as to why this functionality is necessary, I think this patch is harmful.

• File bitbang_spi.c:

  • Patch Set #1, Line 78: bitbang_spi_xfer(

    this is its own patch.

    I would not approve of such a patch either. Having two separate functions for read and write is much more efficient, and speed matters when bitbanging.

To view, visit change 49255. To unsubscribe, or for help writing mail filters, visit settings.