David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30154 )
Change subject: libflashrom.h: Remove line breaks in function signatures ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30154/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30154/1//COMMIT_MSG@9 PS1, Line 9: I was once told we avoid such line breaks for better grep'ability. Not sure who said that, but AFAIK the argument usually applies to print statements.
https://review.coreboot.org/#/c/30154/1/libflashrom.h File libflashrom.h:
https://review.coreboot.org/#/c/30154/1/libflashrom.h@66 PS1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length); Doesn't this exceed the length limit now? (Heck, did we ever write down a length limit in a wiki somewhere, or does that only exist in a mailing discussion that's been buried for years now?)