View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 9: I was once told we avoid such line breaks for better grep'ability.

    Not sure who said that, but AFAIK the argument usually applies to print statements.

• File libflashrom.h:

  • Patch Set #1, Line 66: int flashrom_layout_read_fmap_from_rom(struct flashrom_layout **, struct flashrom_flashctx *, off_t offset, size_t length);

    Doesn't this exceed the length limit now? (Heck, did we ever write down a length limit in a wiki somewhere, or does that only exist in a mailing discussion that's been buried for years now?)

To view, visit change 30154. To unsubscribe, or for help writing mail filters, visit settings.