Attention is currently required from: Miklós Márton, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62878 )
Change subject: Improve IO permission error messages ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62878/comment/6dfb9196_c7a076a6 PS2, Line 7: Improve IO permission error messages We typically add prefix to commit title, so here it can be `hwaccess_x86_io:<the rest of title>`
https://review.coreboot.org/c/flashrom/+/62878/comment/b7eb4333_04e2cb67 PS2, Line 9: - Display the BSD hints only when compiled for a specific BSD : - On Linux check the user's uid to see if flashrom run with root privileges : - Add a note about the dmesg check if the flashrom run as root and have no : IO privilege Seems like lines are longer than 72 chars and wrap. We have max line length 72 chars for commit message.
Patchset:
PS2: Thanks for the patch! I am wondering if you can add testing info in commit message? (if you did testing)