Attention is currently required from: Miklós Márton, Thomas Heijligen.

Patch set 2:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 7: Improve IO permission error messages

    We typically add prefix to commit title, so here it can be
    `hwaccess_x86_io:<the rest of title>`

  • Patch Set #2, Line 9:

    - Display the BSD hints only when compiled for a specific BSD
    - On Linux check the user's uid to see if flashrom run with root privileges
    - Add a note about the dmesg check if the flashrom run as root and have no
      IO privilege
    

    Seems like lines are longer than 72 chars and wrap.
    We have max line length 72 chars for commit message.

• Patchset:

  • Patch Set #2:

    Thanks for the patch! I am wondering if you can add testing info in commit message? (if you did testing)

To view, visit change 62878. To unsubscribe, or for help writing mail filters, visit settings.