Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33034 )
Change subject: [WIP]spi25.c: Implement fast read ......................................................................
Patch Set 1:
(1 comment)
Do we need a separate flag for FAST_READ support in flashchips.c?
I'd say yes, it seems unlikely that all chips support it. And even if, who'd check all the datasheets?
https://review.coreboot.org/#/c/33034/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33034/1//COMMIT_MSG@9 PS1, Line 9: by default Please don't. It's slower for most common flashrom use cases.
I guess a good heuristic would be if we are above the flash chip's threshold for the regular read (say >30MHz if the database doesn't state otherwise). Shouldn't be hard to implement as there are few supported programmers that can go that fast.
Make it a lowest common threshold of flash and programmer to cover the `ichspi` case?