[flashrom-gerrit] Change in flashrom[master]: Add support for Intel Emmitsburg PCH

[David Hendricks (Code Review)]

Attention is currently required from: Jonathan Zhang.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54965 )

Change subject: Add support for Intel Emmitsburg PCH
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS1:
> Did anybody look into it?

Yes, and IMO we should find a better heuristic or require the user to specify a ICH/PCH generation or PCI ID when the programmer is not "internal".

ICCRIBA is obsolete and is reserved on chipsets for the past several years (6-series was the newest chipset with it AFAICT), so checking `if (content->ICCRIBA == 0x00)` works by accident in most cases it seems. The ISL/PSL field shows inconsistent results between what's documented and what's in BKC images.

Ibex Peak (5-series?) seems obsolete. I can't even find a SPI programming guide for it, though maybe you have a document number handy?