Attention is currently required from: Jonathan Zhang.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Did anybody look into it?

    Yes, and IMO we should find a better heuristic or require the user to specify a ICH/PCH generation or PCI ID when the programmer is not "internal".

    ICCRIBA is obsolete and is reserved on chipsets for the past several years (6-series was the newest chipset with it AFAICT), so checking `if (content->ICCRIBA == 0x00)` works by accident in most cases it seems. The ISL/PSL field shows inconsistent results between what's documented and what's in BKC images.

    Ibex Peak (5-series?) seems obsolete. I can't even find a SPI programming guide for it, though maybe you have a document number handy?

To view, visit change 54965. To unsubscribe, or for help writing mail filters, visit settings.