Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33931 )
Change subject: flashchips.c: Sort file by vendor and model ......................................................................
Patch Set 7:
Patch Set 7: Code-Review+1
Hi Nico, are we good to go on this particular one?
Absolutely not. Did you review the 5k lines patch? I would do some testing on my own, probably add a few lines of C that prints the database to compare before/after the patch.
It's good that you ask btw. Your sudden appearance in the flashrom developers group in Gerrit already caused some friction. I don't know if any other member knows about that? I know that you are up to the task, it just caught me by surprise. And technically, with zero contributions to flashrom proper, you wouldn't even be in a reviewer group if we had one separate from coreboot's ;)