Patch Set 7: Code-Review+1

Hi Nico, are we good to go on this particular one?

Absolutely not. Did you review the 5k lines patch? I would
do some testing on my own, probably add a few lines of C
that prints the database to compare before/after the patch.

It's good that you ask btw. Your sudden appearance in the
flashrom developers group in Gerrit already caused some
friction. I don't know if any other member knows about
that? I know that you are up to the task, it just caught
me by surprise. And technically, with zero contributions
to flashrom proper, you wouldn't even be in a reviewer
group if we had one separate from coreboot's ;)

View Change

To view, visit change 33931. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75a99583592526f60ba5264e92391bf8b1213b20
Gerrit-Change-Number: 33931
Gerrit-PatchSet: 7
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 04 Jul 2019 16:02:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment