Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44073 )
Change subject: sb600spi.c: Fix for 0x790b rev 0x61 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG@7 PS1, Line 7: 0x790b rev 0x61
Does this device have a prettier name?
I think just Ryzen? I barely follow all the marketing names now.
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG@9 PS1, Line 9: Note that the : read callback requires a memory mapping.
Why does read now require memory mapping? Does it affect original Yangtze?
It doesn't work without it? Unfortunately cros just doesn't have the quality of commit message that we have here so it is hard to find the historical context.
As far as I am aware this doesn't regress although I do not have the precise hardware to confirm.