View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: 0x790b rev 0x61
Does this device have a prettier name?
I think just Ryzen? I barely follow all the marketing names now.
Patch Set #1, Line 9:
Note that the
read callback requires a memory mapping.
Why does read now require memory mapping? Does it affect original Yangtze?
It doesn't work without it? Unfortunately cros just doesn't have the quality of commit message that we have here so it is hard to find the historical context.
As far as I am aware this doesn't regress although I do not have the precise hardware to confirm.
To view, visit change 44073. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5ce63b5de863aed0442cb4ffeff981e9b2fa445b
Gerrit-Change-Number: 44073
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Kangheui Won <khwon@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 02 Aug 2020 04:35:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment