Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 )
Change subject: tests: Convert selfcheck to unit tests ......................................................................
Patch Set 5:
(2 comments)
File tests/well_formed_tables.c:
https://review.coreboot.org/c/flashrom/+/69620/comment/054ad0d1_46da5d5b PS5, Line 54: flashchips[i].name `chip->name` ?
https://review.coreboot.org/c/flashrom/+/69620/comment/6d026a1a_571b415a PS5, Line 73: if ((b->first_vendor == 0 || b->first_device == 0 || b->second_vendor == 0 : || b->second_device == 0) : || ((b->lb_vendor == NULL) ^ (b->lb_part == NULL)) : || (b->max_rom_decode_parallel == 0 && b->enable == NULL)) This rather large predicate could be tighten up by canonicalisation of the two patterns `x == 0` and `x == NULL` with `!x`.