Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Evan Benn.

View Change

2 comments:

• File tests/well_formed_tables.c:

  • Patch Set #5, Line 54: flashchips[i].name

    `chip->name` ?

  • Patch Set #5, Line 73:

    		if ((b->first_vendor == 0 || b->first_device == 0 || b->second_vendor == 0
    		     || b->second_device == 0)
    		    || ((b->lb_vendor == NULL) ^ (b->lb_part == NULL))
    		    || (b->max_rom_decode_parallel == 0 && b->enable == NULL))
    

    This rather large predicate could be tighten up by canonicalisation of the two patterns `x == 0` and `x == NULL` with `!x`.

To view, visit change 69620. To unsubscribe, or for help writing mail filters, visit settings.