Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes.
Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email )
Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
I rebased, and changed the test to also use new function from libflashrom API.
In addition to unit tests, I ran two tests locally to test the cli, all successful:
flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -r dump.rom --progress
flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -E --progress
I approve, but also I might go around ask another pair of eyes to have a look (since now I am a co-developer of this patch :) ).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 5
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Sat, 09 Nov 2024 08:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes