Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes.

Patch set 5:Code-Review +2

View Change

1 comment:

• Patchset:

  • Patch Set #5:

    I rebased, and changed the test to also use new function from libflashrom API.
    In addition to unit tests, I ran two tests locally to test the cli, all successful:

    flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -r dump.rom --progress
    flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -E --progress

    I approve, but also I might go around ask another pair of eyes to have a look (since now I am a co-developer of this patch :) ).

To view, visit change 64663. To unsubscribe, or for help writing mail filters, visit settings.