[flashrom-gerrit] Change in flashrom[master]: cli_classic: Tidy up some repeated handling patterns into funcs

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35611 )

Change subject: cli_classic: Tidy up some repeated handling patterns into funcs
......................................................................

Patch Set 5: Code-Review+1

(3 comments)

Looks good, I just wonder why the printing order is changed?

https://review.coreboot.org/c/flashrom/+/35611/2/cli_classic.c 
File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/35611/2/cli_classic.c@74 
PS2, Line 74: static void cli_classic_abort_usage(const char *msg)
> Sounds a bit unrelated to this change, maybe it should go into the compiler warn cleanups I saw sinc […]

Ack

https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c 
File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c@79 
PS5, Line 79: 	if (msg)
            : 		fprintf(stderr, "%s", msg);
Shouldn't this be the first message?

https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c@293 
PS5, Line 293: 				"in. Aborting.\n");
nit, does it fit in a single line?