Looks good, I just wonder why the printing order is changed?

Patch set 5:Code-Review +1

View Change

3 comments:

• File cli_classic.c:

  • Patch Set #2, Line 74: static void cli_classic_abort_usage(const char *msg)

    Sounds a bit unrelated to this change, maybe it should go into the compiler warn cleanups I saw sinc […]

    Ack

• File cli_classic.c:

  • Patch Set #5, Line 79:

    	if (msg)
    		fprintf(stderr, "%s", msg);
    

    Shouldn't this be the first message?

  • Patch Set #5, Line 293: "in. Aborting.\n");

    nit, does it fit in a single line?

To view, visit change 35611. To unsubscribe, or for help writing mail filters, visit settings.