Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33997 )
Change subject: flashchips.h: merge definitions from Chromium fork ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/flashrom/+/33997/2/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/33997/2/flashchips.h@400 PS2, Line 400: GIGADEVICE_GD25LQ128CD
Is there no user of this in flashchips. […]
There is. I have updated flashchips.c to match.
https://review.coreboot.org/c/flashrom/+/33997/2/flashchips.h@470 PS2, Line 470: #define INTEL_HWSEQ 0xFFFE /* dummy ID for hardware sequencing */
There is some hwseq support here in upstream, but I don't know much about it.
I see. Yes, it makes sense to add this ID in the change that uses it. Will remove for now. This will be the one remaining difference in flashchips.h between upstream and downstream, so should be easy enough to track.
Have also updated the commit message accordingly.