View Change
2 comments:
File flashchips.h:
Patch Set #2, Line 400: GIGADEVICE_GD25LQ128CD
Is there no user of this in flashchips. […]
There is. I have updated flashchips.c to match.
Patch Set #2, Line 470: #define INTEL_HWSEQ 0xFFFE /* dummy ID for hardware sequencing */
There is some hwseq support here in upstream, but I don't know much about it.
I see. Yes, it makes sense to add this ID in the change that uses it. Will remove for now. This will be the one remaining difference in flashchips.h between upstream and downstream, so should be easy enough to track.
Have also updated the commit message accordingly.
To view, visit change 33997. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie280f351045bdcbc454d6f829fc071af820382b1
Gerrit-Change-Number: 33997
Gerrit-PatchSet: 5
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 04 Jul 2019 06:31:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment