Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c@a76 PS5, Line 76: #ifdef LPC_IO : static unsigned int shm_io_base; : #endif :
to satisfy my curiosity, why did we get rid of this preprocessor stuff?
I would say, this preprocessor stuff is not needed anymore. Prior to this, not using shm_io_base would produce compiler warning. However now shm_io_base is a member of a struct and compiler does not warn if the individual member of the struct is unused as long as struct is used.