View Change
1 comment:
File it85spi.c:
Patch Set #5, Line 76:
#ifdef LPC_IO
static unsigned int shm_io_base;
#endif
to satisfy my curiosity, why did we get rid of this preprocessor stuff?
I would say, this preprocessor stuff is not needed anymore. Prior to this, not using shm_io_base would produce compiler warning. However now shm_io_base is a member of a struct and compiler does not warn if the individual member of the struct is unused as long as struct is used.
To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Eizan Miyamoto <eizan@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 24 Nov 2020 03:08:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eizan Miyamoto <eizan@chromium.org>
Gerrit-MessageType: comment