[flashrom-gerrit] [M] Change in flashrom[master]: tests: Convert selfcheck to unit tests

[Felix Singer (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Evan Benn.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 )

Change subject: tests: Convert selfcheck to unit tests
......................................................................

Patch Set 6:

(2 comments)

File tests/well_formed_tables.c:

https://review.coreboot.org/c/flashrom/+/69620/comment/17a2733c_4ba99a33 
PS6, Line 24: 	do {                                                                                   \
            : 		if (!(assertion))                                                              \
            : 			fail_msg(#assertion " is false for index:%zu name:%s", (index),        \
            : 				 (name) ? (name) : "unknown");                                 \
            : 	} while (0)
I'm confused. Why is this a do-while? Is it really needed? It just runs one time.

https://review.coreboot.org/c/flashrom/+/69620/comment/01f96b9e_1ee73877 
PS6, Line 71: 		assert_table(b->board_name, i, b->board_name);
            : 		assert_table(b->board_name, i, b->board_name);
The same line twice. Is this intended?