Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Evan Benn.

View Change

2 comments:

• File tests/well_formed_tables.c:

  • Patch Set #6, Line 24:

    	do {                                                                                   \
    		if (!(assertion))                                                              \
    			fail_msg(#assertion " is false for index:%zu name:%s", (index),        \
    				 (name) ? (name) : "unknown");                                 \
    	} while (0)
    

    I'm confused. Why is this a do-while? Is it really needed? It just runs one time.

  • Patch Set #6, Line 71:

    		assert_table(b->board_name, i, b->board_name);
    		assert_table(b->board_name, i, b->board_name);
    

    The same line twice. Is this intended?

To view, visit change 69620. To unsubscribe, or for help writing mail filters, visit settings.