Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropiate variables with bool ......................................................................
Patch Set 9:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/89f315de_50aac599 PS7, Line 872: write_cmd = true;
Agree, but that's something for another patch series. Marking as resolved.
Why? It achieves the same goal, but better. IMO, this patch alone is not worth the noise in the commit history. Changing the same lines over and over again also unnecessarily drains review resources. (Also not nice to change the style that the original author choose, IMO.)