Attention is currently required from: Felix Singer.
View Change
1 comment:
File ichspi.c:
Patch Set #7, Line 872: write_cmd = true;
Agree, but that's something for another patch series. Marking as resolved.
Why? It achieves the same goal, but better. IMO, this patch alone is not worth
the noise in the commit history. Changing the same lines over and over again also
unnecessarily drains review resources. (Also not nice to change the style that the
original author choose, IMO.)
To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830
Gerrit-Change-Number: 66892
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Comment-Date: Fri, 02 Sep 2022 11:46:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment