Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57269 )
Change subject: tests: Add NON_ZERO macro and not_null function instead of MOCK_HANDLE ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: I updated commit message to reflect the latest changes in the patch.
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/57269/comment/2ce7f523_d1949be5 PS1, Line 37: NOT
Would you agree on NON_ZERO (with underscore)? I think it's a bit more readable.
I renamed macro to NON_ZERO
https://review.coreboot.org/c/flashrom/+/57269/comment/a6c79efb_71939709 PS1, Line 38: NOT_NULL ((void *)NOT_ZERO)
Is it ok for this stub function to be in this header? […]
I created not_null() function, but left NON_ZERO as macro, is this what you meant, or you meant them both to be functions (non_zero and not_null)? Also I added io_mock.c, is this correct approach? Thank you!