Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    I updated commit message to reflect the latest changes in the patch.

• File tests/io_mock.h:

  • Patch Set #1, Line 37: NOT

    Would you agree on NON_ZERO (with underscore)? I think it's a bit more readable.

    I renamed macro to NON_ZERO

  • Patch Set #1, Line 38: NOT_NULL ((void *)NOT_ZERO)

    Is it ok for this stub function to be in this header? […]

    I created not_null() function, but left NON_ZERO as macro, is this what you meant, or you meant them both to be functions (non_zero and not_null)?
    Also I added io_mock.c, is this correct approach?
    Thank you!

To view, visit change 57269. To unsubscribe, or for help writing mail filters, visit settings.