Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33543 )
Change subject: layout: Introduce flashrom_layout_new()
......................................................................
Patch Set 8:
(1 comment)
File layout.c:
https://review.coreboot.org/c/flashrom/+/33543/comment/9f9ba7fa_7cca42de
PS5, Line 397: malloc
Yes, that was the idea. […]
I added an initializer now. Should be clear that unmentioned fields
are 0 this way. Let me know what you think.
I'd prefer an anonymous struct. But I think it's better to start
using new features (C11) after a release.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2ae7246493ff592e631cce924777925c7825e398
Gerrit-Change-Number: 33543
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sat, 26 Jun 2021 00:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment