[flashrom-gerrit] Change in flashrom[master]: layout: Introduce flashrom_layout_new()

[Nico Huber (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33543 )

Change subject: layout: Introduce flashrom_layout_new()
......................................................................


Patch Set 8:

(1 comment)

File layout.c:

https://review.coreboot.org/c/flashrom/+/33543/comment/9f9ba7fa_7cca42de 
PS5, Line 397: malloc
> Yes, that was the idea. […]
> I added an initializer now. Should be clear that unmentioned fields
> are 0 this way. Let me know what you think.

I'd prefer an anonymous struct. But I think it's better to start
using new features (C11) after a release.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/33543
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2ae7246493ff592e631cce924777925c7825e398
Gerrit-Change-Number: 33543
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Daniel Campello <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: Thomas Heijligen <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Daniel Campello <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Sat, 26 Jun 2021 00:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Edward O'Callaghan <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Comment-In-Reply-To: Peter Marheine <[e-mail]>
Gerrit-MessageType: comment