Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34595 )
Change subject: flashchips: add W25M512JV ......................................................................
Patch Set 1:
(5 comments)
Hi Joel,
this seems like work-in-progress? I've left some comments anyway. There seems to be a little con- fusion between W25M512JV and W25Q512JV. Adding the latter would be easier and seems more likely, but you should look for the correct datasheet.
https://review.coreboot.org/c/flashrom/+/34595/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34595/1//COMMIT_MSG@7 PS1, Line 7: W25M512JV Code says W25*Q*512JV
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c File flashchips.c:
PS1: Please keep entries in this file sorted by `.vendor` and `.name`.
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15910 PS1, Line 15910: 1024 Datasheet says 256 as usual?
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15912 PS1, Line 15912: .tested = TEST_OK_PREW, Seems like this needs an update.
https://review.coreboot.org/c/flashrom/+/34595/1/flashchips.c@15914 PS1, Line 15914: .probe_timing = TIMING_ZERO, You'll have to add some erase functions to `.block_erasers`. They are mostly the same across flash-chip families, i.e. those for W25Q256JV should work here, too. Only the block counts / size for bulk erase need to be adapted.