Hi Joel,

this seems like work-in-progress? I've left some
comments anyway. There seems to be a little con-
fusion between W25M512JV and W25Q512JV. Adding
the latter would be easier and seems more likely,
but you should look for the correct datasheet.

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 7: W25M512JV

    Code says W25*Q*512JV

• File flashchips.c:

  • Patch Set #1:

    Please keep entries in this file sorted by `.vendor` and `.name`.

  • Patch Set #1, Line 15910: 1024

    Datasheet says 256 as usual?

  • Patch Set #1, Line 15912: .tested = TEST_OK_PREW,

    Seems like this needs an update.

  • Patch Set #1, Line 15914: .probe_timing = TIMING_ZERO,

    You'll have to add some erase functions to `.block_erasers`. They
    are mostly the same across flash-chip families, i.e. those for
    W25Q256JV should work here, too. Only the block counts / size
    for bulk erase need to be adapted.

To view, visit change 34595. To unsubscribe, or for help writing mail filters, visit settings.