30 Nov
2022
30 Nov
'22
11:20 a.m.
Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69129 )
Change subject: writeprotect,ichspi,spi25: handle register access constraints ......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/69129/comment/17d43d8c_4572206b PS7, Line 133: /* Some SPI masters like ICH7/ICH9 block opcodes for writing SR2/SR3/etc. */
I thought so too but when I was debugging cyan/wizpig failures in b/240229722 I found that it didn't […]
Can you include that bug in the commit message to trace things back when required.
--
To view, visit https://review.coreboot.org/c/flashrom/+/69129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2145749dcc51f4556550650dab5aa1049f879c45
Gerrit-Change-Number: 69129
Gerrit-PatchSet: 13
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Wed, 30 Nov 2022 10:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment