Attention is currently required from: Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: Add unit test to run init/shutdown for enabled drivers ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hello! Just to check on this: with a +1 can I assume this is moving to the right direction, and I ca […]
I usually give a +1 when I haven't noticed anything blatantly wrong with a change, but I'm not sure enough about it to give a +2. In this case, I don't know enough about testing to give a +2 without having heard from others first.
But yes, I'd say this is moving in the right direction and I'd look into adding more tests. If the change would grow very large, I'd split it into several smaller changes.