Attention is currently required from: Anastasia Klimchuk.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Hello! Just to check on this: with a +1 can I assume this is moving to the right direction, and I ca […]

    I usually give a +1 when I haven't noticed anything blatantly wrong with a change, but I'm not sure enough about it to give a +2. In this case, I don't know enough about testing to give a +2 without having heard from others first.

    But yes, I'd say this is moving in the right direction and I'd look into adding more tests. If the change would grow very large, I'd split it into several smaller changes.

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.