Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 )
Change subject: tests: Do not run a test if its driver is not built ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55295/comment/7eb1f553_18538c5d PS5, Line 10: however config options can be disabled and in that case test should : not be run.
What was discussed exactly? […]
I'd even say it's better to return back to this later. Why switch to another scheme before we have seen how this one turns out? I grasp from the name `init_shutdown.c` that the idea was to have individual files per tested path. Once we try to add another file, we'll probably much easier see what the advantages and disadvan- tages are.
As stated earlier, missing dependencies might be a reason to favor per programmer files. For instance if we need some library's header file to compile the test code. But that's a problem that I'd try to solve only once it's clear to exist :)
As for weak functions. I'd rather clutter the code with
if (CONFIG(MEC1308))
than with weak declarations. In the only project I know that makes heavily use of weak symbols (coreboot) they often turn bad.