Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
1 comment:
Commit Message:
however config options can be disabled and in that case test should
not be run.
>>>What was discussed exactly? […]
I'd even say it's better to return back to this later. Why switch
to another scheme before we have seen how this one turns out? I
grasp from the name `init_shutdown.c` that the idea was to have
individual files per tested path. Once we try to add another file,
we'll probably much easier see what the advantages and disadvan-
tages are.
As stated earlier, missing dependencies might be a reason to favor
per programmer files. For instance if we need some library's
header file to compile the test code. But that's a problem that
I'd try to solve only once it's clear to exist :)
As for weak functions. I'd rather clutter the code with
if (CONFIG(MEC1308))
than with weak declarations. In the only project I know that makes
heavily use of weak symbols (coreboot) they often turn bad.
To view, visit change 55295. To unsubscribe, or for help writing mail filters, visit settings.