Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Adds support for USB SPI protocol V2 ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@854 PS2, Line 854: } if Um, missing an else?
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@855 PS2, Line 855: PACKET_ID_V2_RESPONSE_CONTINUE) {
I think it's 79 (w/ 4 tabs) characters, I'll switch it if it's still reasonable.
right, I have Gerrit configured as 96-character width (coreboot uses that). Not a big deal
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@864 PS2, Line 864: msg_perr("Raiden: Unexpected packet id = %d", Maybe you can swap the if/else branches to drop one indentation level on the currently-if block?
https://review.coreboot.org/c/flashrom/+/41533/2/raiden_debug_spi.c@913 PS2, Line 913: } else {
I can add these as function pointers in 'struct raiden_debug_spi_data'. […]
Or even, make sure that those function pointers can never be null in the first place. If a programmer does not support an operation, one could have an error-returning stub there instead of a null that needs to be checked all the time