View Change

4 comments:

• File raiden_debug_spi.c:

  • Patch Set #2, Line 854: } if

    Um, missing an else?

  • Patch Set #2, Line 855: PACKET_ID_V2_RESPONSE_CONTINUE) {

    I think it's 79 (w/ 4 tabs) characters, I'll switch it if it's still reasonable.

    right, I have Gerrit configured as 96-character width (coreboot uses that). Not a big deal

  • Patch Set #2, Line 864: msg_perr("Raiden: Unexpected packet id = %d",

    Maybe you can swap the if/else branches to drop one indentation level on the currently-if block?

  • Patch Set #2, Line 913: } else {

    I can add these as function pointers in 'struct raiden_debug_spi_data'. […]

    Or even, make sure that those function pointers can never be null in the first place. If a programmer does not support an operation, one could have an error-returning stub there instead of a null that needs to be checked all the time

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.